Make extract_last_comment 65x faster#77
Closed
symwell wants to merge 7 commits intobanister:masterfrom
Closed
Conversation
… last few lines of the file instead of go over all of them
symwell
changed the title
extract_last_comment 3x fasterextract_last_comment 65x faster
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed. Superceded by #78
In
extract_last_commentdon't go over all lines of the file if the last comment is in the last 100 lines.When used with a benchmark that called
extract_last_comment56411 times:this improved performance by 3.42x (reduced execution time from20.15sto5.89s)20.15sto0.31s) when parsing comments backwards.when the median number of lines in the opened files was 264 lines.I tried to tune this with a different threshold, like 50-80 lines or 150-500 lines, and ~100 lines worked well for the benchmark used.